Backport 26786 ([rescue] Permit ROM_EXT updates via rescue ) #29163
+220
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
cfrantz,
jwnrt,
moidx and
timothytrippel
and removed request for
a team
Rather than passing `bootdata` and `boot_log` along in every call, store pointers to them into the `rescue_state_t` structure. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 1213c98)
Discussion in lowRISC#26785. 1. Examine the first rescue block and determine if the rescue stream contains a ROM_EXT. 2. If the rescue stream contains a ROM_EXT _and_ we're performing rescue to the non-active flash slot, then erase and reprogram the inactive ROM_EXT area. Otherwise, silently consume the ROM_EXT portion of the rescue stream and flash the application payload. 3. Test that each combination of rom_ext slot and rescue slot always results in the inactive rom_ext slot updating and the active slot not updating. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit ab4b517)
pamaury
force-pushed
the
backport_26786
branch
from
df07feb to
614edcf
Compare
cfrantz
approved these changes
Jan 28, 2026
Contributor
Author
|
CI failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26786