Backport 27247 (Provide a means of setting the expected success string at run time) #29181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
cfrantz,
jwnrt and
timothytrippel
and removed request for
a team
pamaury
force-pushed
the
backport_27247
branch
from
423f445 to
47895b9
Compare
To avoid cyclic dependency when SKU code needs to use the response structure, move the structure from ft_lib (which depends on the SKU code) into util_lib. The end to end personalization test still passes. Signed-off-by: Vadim Bendebury <[email protected]> (cherry picked from commit d8253e3)
When wating for successful post personalization restart in some cases the text printed on the device console is not static and depends on data generted during personalization. Modify ft_ext() prototype to accept the response structure and to return a String Option which the host would mix in with the constant success string when defining the expected console output. Tested with an updated Cros image which generates dev seed report. Signed-off-by: Vadim Bendebury <[email protected]> (cherry picked from commit 0f19189)
pamaury
force-pushed
the
backport_27247
branch
from
47895b9 to
1270950
Compare
cfrantz
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27247. NOTE: despite what the GitHub UI says, #27247 actually only has two commits because the one is a subset of 9a66cc2 which was previously merged on earlgrey_1.0.0. So it appears that GH was happy to silently ignore the empty commit when merging.