Backport 27041 ([rom_ext] Clear power-on-reset in self-requested reboots) #29213
+234
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add a `no-op` mode to rescue so that the xmodem protocol is functional if the owner disables the `RescueFirwmare` command. 2. Make the `no-op` mode the default if `RescueFirmware` is absent from the allowed commands list. Fixes lowRISC#26919. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit a147e46)
The `--reboot` flag on `rescue` commands needs to parse its arguments. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 6af8f88)
Test that the rescue protocol is functional when the `RescueFirmware` mode is not in the list of allowed commands. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 23b5b87)
Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 4295c6f)
Test that the ROM_EXT clears `PowerOnReset` when it reboots so that it preserves any boot_svc message sent to itself. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit a9d9c94)
pamaury
force-pushed
the
backport_27041
branch
from
2f4b66a to
72569a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27041. Depends on #29208, only review last 2 commits.