[aes] Upstream support for GCM - Part 17 #29220
Open
+1,171
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the nist_vectors_gcm test to the DV environment. In this test, the testbench reads in four different NIST AES-GCM reference vectors and performs encryptions/tag generations/ decryptions. The output is compared to the NIST reference. Signed-off-by: Pascal Nasahl <[email protected]>
This commit adds the basic aes_gcm_test to the top-level test framework. Signed-off-by: Pascal Nasahl <[email protected]>
Only check if we are reseeding when we actually start the cipher core. Signed-off-by: Pascal Nasahl <[email protected]>
This commit adds the following parameters to the c_dpi_aes_crypt_message interface: - Message length - AAD Length - Error result code of the underlying library Previously, the first two parameters (length) were generate by simply using the size() of the input vector. However, as this input vector is always a multiple of 16 bytes, sub-blocks smaller than 16 bytes are not supported. As we need this for the AES-GCM mode, add a dedicated length parameter to the interface. Moreover, this commit also enables that the c_dpi_aes_crypt_message function returns the error code that is generated by the underyling crypto lib. This is important as, when in GCM mode, a tag mismatch during decryption is signaled using this error code. Signed-off-by: Pascal Nasahl <[email protected]>
This commit adds the AES-GCM mode to the base AES DV sequence. To demonstrate that this is working, this commit enables the AES-GCM mode in the smoke test. Signed-off-by: Pascal Nasahl <[email protected]>
This commit enables the AES-GCM mode in the config_error_test. Signed-off-by: Pascal Nasahl <[email protected]>
vogelpi
requested review from
andrea-caforio,
eshapira and
nasahlpa
and removed request for
a team and
eshapira
Member
|
The failing DV tests should be fixed with: |
Contributor
Author
|
Thanks @nasahlpa for your feedback, I should probably combine all these two additional PRs vogelpi#25 and vogelpi#26 into this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 17th PR of a series of PRs to upstream support for AES-GCM. The original PR can be found here: vogelpi#19
This PR contains several commits that integrate the new AES-GCM mode into the UVM test bench.