[otbn,smoke] Make smoke test independent of REPO_TOP#29243
Merged
rswarbrick merged 1 commit intolowRISC:masterfrom Feb 5, 2026
Merged
[otbn,smoke] Make smoke test independent of REPO_TOP#29243rswarbrick merged 1 commit intolowRISC:masterfrom
rswarbrick merged 1 commit intolowRISC:masterfrom
Conversation
This makes the OTBN smoke test script independent of the REPO_TOP environment variable. This is helpful when one has multiple clones of the OpenTitan repo. Signed-off-by: Pascal Etterli <pascal.etterli@lowrisc.org>
etterli
requested review from
h-filali,
marnovandermaas and
rswarbrick
and removed request for
a team and
marnovandermaas
Contributor
Author
|
I don't see the value of depending on the REPO_TOP variable. If the script moves, the path can easily be adapted. |
Contributor
Author
|
It also makes the script compatible with the case REPO_TOP is not set at all. This case is currently already supported by the otbn simulator framework. |
rswarbrick
approved these changes
Feb 5, 2026
Contributor
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
The ugliness was from a designer who (arguably) bodged things together here. This looks much more sensible to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the OTBN smoke test script independent of the REPO_TOP environment variable. This is helpful when one has multiple clones of the OpenTitan repo.