[aes] Upstream support for GCM - Part 20#29267
Merged
vogelpi merged 1 commit intolowRISC:masterfrom Feb 6, 2026
Merged
Conversation
When performing alert or FI tests, the try_recover() function in the base sequence splits up messages. E.g.: |AAD|AAD|PTX|PTX|TAG| could be split up into |AAD|PTX|PTX|TAG when there is an error injected at the first AAD block. This is problematic as now len(aad) || len(data), which is the data_in of the TAG block, does not match anymore. Hence, the tag comparison fails. This commit now recomputes len(aad) || len(data) at puts it into the correct AES_GCM_TAG item. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
vogelpi
requested review from
andrea-caforio,
eshapira and
nasahlpa
and removed request for
a team and
eshapira
nasahlpa
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the 20th PR of a series of PRs to upstream support for AES-GCM. The original PR can be found here: vogelpi#28
[aes,dv] Recalculate aad/ptx length when splitting message
When performing alert or FI tests, the try_recover() function in the base sequence splits up messages.
E.g.:
|AAD|AAD|PTX|PTX|TAG|
could be split up into
|AAD|PTX|PTX|TAG
when there is an error injected at the first AAD block.
This is problematic as now len(aad) || len(data), which is the data_in of the TAG block, does not match anymore. Hence, the tag comparison fails.
This commit now recomputes len(aad) || len(data) at puts it into the correct AES_GCM_TAG item.