[jtag,dv] Avoid going to Run-Test/Idle when unnecessary#29627
Open
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Open
[jtag,dv] Avoid going to Run-Test/Idle when unnecessary#29627rswarbrick wants to merge 1 commit intolowRISC:masterfrom
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Conversation
This commit tidies up the driver a bit, adding careful notes about the FSM state we expect at the start/end of various tasks. The important bit is that we no longer go to Run-Test/Idle unconditionally after IR and DR transactions. The resulting code should now go through FSM edges Update-*R -> Select-DR, which weren't previously getting hit. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
requested review from
marnovandermaas
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit tidies up the driver a bit, adding careful notes about the FSM state we expect at the start/end of various tasks. The important bit is that we no longer go to Run-Test/Idle unconditionally after IR and DR transactions.
The resulting code should now go through FSM edges Update-*R -> Select-DR, which weren't previously getting hit.
(This is an ancient commit from 2024(!). I made it in order to exercise some FSM edges in the debug module TAP)