Open
Conversation
No functional change (but I hope that this makes it easier to glance through the file). Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
KinzaQamar
approved these changes
Mar 31, 2026
Contributor
KinzaQamar
left a comment
KinzaQamar
left a comment
There was a problem hiding this comment.
I left a boring comment otherwise LGTM
KinzaQamar
reviewed
Apr 1, 2026
hw/dv/sv/cip_lib/cip_base_env.sv
Outdated
| typedef push_pull_agent#(.DeviceDataWidth(EDN_DATA_WIDTH)) edn_push_pull_agent_t; | ||
| typedef push_pull_agent_cfg#(.DeviceDataWidth(EDN_DATA_WIDTH)) edn_push_pull_agent_cfg_t; | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
This is an extra blank line
Contributor
Author
There was a problem hiding this comment.
Good point. I suspect I thought it made things clearer, but I've reconsidered :-) Now updated.
Also mark some internal variables local and add a typedef to avoid very long lines for EDN pull agents. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
cip-base-env-tidyup
branch
from
ad3a00e to
18ac026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big change (by lines of code) is the first commit, which switches the code to use out-of-block definitions (with no functional change). The second change adds some documentation comments and makes some class variables local.