Skip to content

[prim,fpv] Waive impossible cover items from async alert fpv#29632

Open
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
rswarbrick:async-alert-cov-waiver
Open

[prim,fpv] Waive impossible cover items from async alert fpv#29632
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
rswarbrick:async-alert-cov-waiver

Conversation

@rswarbrick
Copy link
Copy Markdown
Contributor

These case statement items have no effect on the design, but our style guide suggests including them to make the code more explicit. Unfortunately, Jasper automatically infers cover items for them. Get rid of them.

These case statement items have no effect on the design, but our style
guide suggests including them to make the code more explicit.
Unfortunately, Jasper automatically infers cover items for them. Get
rid of them.

Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
@rswarbrick rswarbrick requested a review from a team as a code owner March 30, 2026 19:00
@rswarbrick rswarbrick added Component:FPV FPV issue: formal testbench, property, etc IP:prim labels Mar 30, 2026
@rswarbrick
Copy link
Copy Markdown
Contributor Author

With these waivers, running the testbench with util/dvsim/dvsim.py --gui hw/top_earlgrey/formal/top_earlgrey_fpv_prim_cfgs.hjson --select-cfg=prim_alert_rxtx_async_fpv gives the following coverage report:
image

The remaining coverage holes are genuine, such as this one:
image
(the default case of a 7-state FSM).

But those need addressing with a separate change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component:FPV FPV issue: formal testbench, property, etc IP:prim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant