Corrections to interrupt handling in plic_tests #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the disabling of interrupts in the `_interrupt_set` functions; these were previously incapable of clearing the mie|mstatus bit. Modify the interrupt timeout loop in plic_tests.hh accordingly. Re-express mcycle 'wfiTimeout' check to be robust against counter wraparound (this takes only about 100 seconds of run time on the Sonata board at 40MHz).
AlexJones0
approved these changes
Jul 25, 2025
Contributor
AlexJones0
left a comment
AlexJones0
left a comment
There was a problem hiding this comment.
Thanks for fixing both these bugs! The wait avoiding the counter wraparound is also much nicer now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the disabling of interrupts in the
_interrupt_setfunctions; these were previously incapable of clearing the mie|mstatus bit. Modify the interrupt timeout loop in plic_tests.hh accordingly.Re-express mcycle 'wfiTimeout' check to be robust against counter wraparound (this takes only about 100 seconds of run time on the Sonata board at 40MHz).