Improve interrupt/exception handling#43
Merged
elliotb-lowrisc merged 1 commit intolowRISC:mainfrom Feb 26, 2025
elliotb-lowrisc:isrs
Merged
Improve interrupt/exception handling#43elliotb-lowrisc merged 1 commit intolowRISC:mainfrom elliotb-lowrisc:isrs
elliotb-lowrisc merged 1 commit intolowRISC:mainfrom
elliotb-lowrisc:isrs
Conversation
Correctly discern interrupts from exceptions. Previously, `_trap_vector` would ignore the `interrupt` bit of the `mcause` CSR. This resulted in some exceptions (e.g. store access fault) to be misdiagnosed as interrupts (e.g. timer interrupt). Also add handling of interrupts outside of the expected three.
Contributor
Author
|
I have tested this with a store access exception that no longer is misdiagnosed as a timer interrupt, and also tested the new unknown interrupt handler by temporarily commenting-out the branch instruction for the external interrupt handler and running a test that invokes an external interrupt. |
marnovandermaas
approved these changes
Feb 21, 2025
Contributor
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Thanks, this looks correct to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly discern interrupts from exceptions.
Previously,
_trap_vectorwould ignore theinterruptbit of themcauseCSR.This resulted in some exceptions (e.g. store access fault) to be misdiagnosed as interrupts (e.g. timer interrupt).
Also add handling of interrupts outside of the expected three.