[hw,dv] Rationalise I/O pads of top_chip_asic#51
Merged
elliotb-lowrisc merged 1 commit intolowRISC:mainfrom Mar 4, 2025
elliotb-lowrisc:pads
Merged
[hw,dv] Rationalise I/O pads of top_chip_asic#51elliotb-lowrisc merged 1 commit intolowRISC:mainfrom elliotb-lowrisc:pads
top_chip_asic#51elliotb-lowrisc merged 1 commit intolowRISC:mainfrom
elliotb-lowrisc:pads
Conversation
The input and output signals for some bidirectional interfaces seem to initially have been connected to different I/O pads in `top_chip_asic` for some unknown reason. Also one pad had different interfaces connected to the input vs. output. Correct this and reduce the number of pads to match.
marnovandermaas
approved these changes
Mar 3, 2025
Contributor
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
I think this looks reasonable to me from a code review. Once you're happy with testing this, feel free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input and output signals for some bidirectional interfaces seem to initially have been connected to different I/O pads in
top_chip_asicfor some unknown reason.Also one pad had different interfaces connected to the input vs. output.
Correct this and reduce the number of pads to match.