Add regex checks for logger timestamps and PIDs #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lplewa
force-pushed
the
main
branch
2 times, most recently
from
b11534f to
cde4cb8
Compare
KFilipek
reviewed
Aug 25, 2025
There was a problem hiding this comment.
LGTM
@KFilipek reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lplewa)
test/utils/utils_log.cpp line 7 at r1 (raw file):
#include "base.hpp" #include "test_helpers.h" #include <regex>
Separate include block
|
There are failing build jobs, please fix it before merge. |
KFilipek
suggested changes
Aug 26, 2025
Comment on lines
+360
to
+363
|
|
||
| std::regex r("^\\[\\d{4}-\\d{2}-\\d{2}T\\d{2}:\\d{2}:\\d{2} DEBUG UMF\\] " | ||
| + MOCK_FN_NAME + ": example log\\n$"); | ||
| EXPECT_TRUE(std::regex_match(last_message, r)); |
There was a problem hiding this comment.
Can you describe this regexp as a comment?
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| #include "base.hpp" | |||
| #include "test_helpers.h" | |||
| #include <regex> | |||
| @@ -257,6 +260,7 @@ TEST_F(test, parseEnv) { | |||
| template <typename... Args> void helper_test_log(Args... args) { | |||
| fput_count = 0; | |||
| fflush_count = 0; | |||
| last_message.clear(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
YYYY-MM-DDTHH:MM:SSformatTesting
cmake --build build -j$(nproc)ctest -R test_logger --output-on-failurehttps://chatgpt.com/codex/tasks/task_e_684823a83050832194419c71f85a46ed
This change is