Skip to content

Development: Fix Ansible deprecation warnings#59

Merged
bensofficial merged 1 commit intomainfrom
fix/ansible-warnings
Mar 5, 2026
Merged

Development: Fix Ansible deprecation warnings#59
bensofficial merged 1 commit intomainfrom
fix/ansible-warnings

Conversation

@bensofficial
Copy link
Member

@bensofficial bensofficial commented Feb 25, 2026

Motivation and Context

ls1intum/artemis-ansible-collection#188

Description

Migrate ansible_managed to normal variable defined globally for all groups.

Summary by CodeRabbit

  • Refactor
    • Reorganized configuration management settings across infrastructure configuration files for improved maintainability and consistency.

@bensofficial bensofficial self-assigned this Feb 25, 2026
@bensofficial bensofficial requested a review from a team as a code owner February 25, 2026 14:58
@bensofficial bensofficial requested a review from Mtze February 25, 2026 14:58
@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25659cb and 2e40842.

📒 Files selected for processing (2)
  • ansible.cfg
  • group_vars/all.yml
💤 Files with no reviewable changes (1)
  • ansible.cfg

📝 Walkthrough

Walkthrough

The ansible_managed variable is relocated from the ansible.cfg file's [defaults] section to group_vars/all.yml, consolidating configuration management directives in the inventory variables rather than the Ansible configuration file.

Changes

Cohort / File(s) Summary
Configuration Relocation
ansible.cfg
Removed the active ansible_managed configuration variable and its explanatory comments from the [defaults] section (−6 lines).
Inventory Variables
group_vars/all.yml
Added ansible_managed variable declaration at the top of the file with a management notice (+2 lines).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A variable hops from config's nest,
To group_vars where it settles best,
Ansible's managed note takes flight,
Configuration organized just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of the PR: fixing Ansible deprecation warnings by migrating ansible_managed configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ansible-warnings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bensofficial bensofficial merged commit 2480786 into main Mar 5, 2026
2 checks passed
@bensofficial bensofficial deleted the fix/ansible-warnings branch March 5, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants