Skip to content

Add support for displaying file sizes in bytes with a separator #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add support for displaying file sizes in bytes with a separator #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
190 changes: 184 additions & 6 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,12 @@ xdg = "2.5"
git2 = { version = "0.18", optional = true, default-features = false }

[target.'cfg(unix)'.dependencies]
num-format = { version = "0.4.4", features = ["with-system-locale"] }
users = { version = "0.11.3", package = "uzers" }
xattr = "1"

[target.'cfg(windows)'.dependencies]
num-format = "0.4.4"
windows = { version = "0.43.0", features = ["Win32_Foundation", "Win32_Security_Authorization", "Win32_Storage_FileSystem", "Win32_System_Memory"] }

[dependencies.clap]
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ recursion:

# == Size ==
# Specifies the format of the size column.
# Possible values: default, short, bytes
# Possible values: default, short, bytes, bytes-with-separator
size: default

# == Permission ==
Expand Down
2 changes: 1 addition & 1 deletion doc/lsd.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ lsd is a ls command with a lot of pretty colours and some other stuff to enrich
: How to display permissions [default: rwx for linux, attributes for windows] [possible values: rwx, octal, attributes, disable]

`--size <size>...`
: How to display size [default: default] [possible values: default, short, bytes]
: How to display size [default: default] [possible values: default, short, bytes, bytes-with-separator]

`--sort <WORD>...`
: Sort by WORD instead of name [possible values: size, time, version, extension, git]
Expand Down
2 changes: 1 addition & 1 deletion src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ pub struct Cli {
pub permission: Option<String>,

/// How to display size [default: default]
#[arg(long, value_name = "MODE", value_parser = ["default", "short", "bytes"])]
#[arg(long, value_name = "MODE", value_parser = ["default", "short", "bytes", "bytes-with-separator"])]
pub size: Option<String>,

/// Display the total size of directories
Expand Down
2 changes: 1 addition & 1 deletion src/config_file.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ recursion:

# == Size ==
# Specifies the format of the size column.
# Possible values: default, short, bytes
# Possible values: default, short, bytes, bytes-with-separator
size: default

# == Permission ==
Expand Down
Loading