Skip to content

Improve icons argument (closes #956) #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve icons argument (closes #956) #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95cef79
fixed #956. Note: This slightly alters the behavior of the --icon fla…
HFDan Nov 16, 2025
4ebb39a
Updated docs to reflect the new behavior of --icon
HFDan Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/lsd.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ lsd is a ls command with a lot of pretty colours and some other stuff to enrich
`--hyperlink <hyperlink>...`
: Attach hyperlink to filenames [default: never] [possible values: always, auto, never]

`--icon <icon>...`
`--icon[=<icon>]...`
: When to print the icons [default: auto] [possible values: always, auto, never]

`--icon-theme <icon-theme>...`
Expand Down
2 changes: 1 addition & 1 deletion src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ pub struct Cli {
pub color: Option<String>,

/// When to print the icons [default: auto]
#[arg(long, value_name = "MODE", value_parser = ["always", "auto", "never"])]
#[arg(long, value_name = "MODE", value_parser = ["always", "auto", "never"], require_equals=true, default_missing_value="always", num_args=0..=1)]
pub icon: Option<String>,

/// Whether to use fancy or unicode icons [default: fancy]
Expand Down