Preserve order of tags when reference tags are mixed with local tags#1486
Open
notEthan wants to merge 3 commits intolsegal:mainfrom
Open
Preserve order of tags when reference tags are mixed with local tags#1486notEthan wants to merge 3 commits intolsegal:mainfrom
notEthan wants to merge 3 commits intolsegal:mainfrom
Conversation
combines @tags and @ref_tags into one array, @all_tags, from which #tags is built
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, ref tags are always rendered after local tags, resulting, for me, in @param tags showing up in a different order than the actual method.
This PR removes separation of ref and local tags, so Docstring#tags can dereference and return tags in the right order.
Completed Tasks
bundle exec rakelocally (if code is attached to PR).