Skip to content

Fix static HTML class list navigation path duplication (#1639) #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carsonclarkemagrab-toast wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

Fix static HTML class list navigation path duplication (#1639) #1647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions templates/default/fulldoc/html/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,12 @@ window.addEventListener(
"message",
async (e) => {
if (e.data.action === "navigate") {
const response = await fetch(e.data.url);
// Resolve the URL against the iframe's location to handle relative paths correctly
const iframe = document.getElementById("nav");
const iframeUrl = iframe ? iframe.contentWindow.location.href : window.location.href;
const resolvedUrl = new URL(e.data.url, iframeUrl).href;

const response = await fetch(resolvedUrl);
const text = await response.text();
const parser = new DOMParser();
const doc = parser.parseFromString(text, "text/html");
Expand Down Expand Up @@ -383,12 +388,12 @@ window.addEventListener(

document.getElementById("class_list_link").classList = classListLink;

const url = new URL(e.data.url, "https://localhost");
const url = new URL(resolvedUrl);
const hash = decodeURIComponent(url.hash ?? "");
if (hash) {
document.getElementById(hash.substring(1)).scrollIntoView();
}
history.pushState({}, document.title, e.data.url);
history.pushState({}, document.title, resolvedUrl);
}
},
false
Expand Down