fix(fixed-position): Use the position as the position on the whell#14
Open
avano wants to merge 1 commit intolsmarsden:mainfrom
Open
fix(fixed-position): Use the position as the position on the whell#14avano wants to merge 1 commit intolsmarsden:mainfrom
avano wants to merge 1 commit intolsmarsden:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
it seemed to me that the fixed-position did not work correctly, or at least not how would I interpret the fixed-position setting.
One issue is that
buttonConfig.position = availablePositions[index];does not modify the buttonConfig object so the position stays unset and the other is that theapplyFixedPositionLayoutcalculates the wheel position based on theindexand notposition.Consider this button card:
the buttons are displayed this way:

where with this PR the buttons are displayed this way:

should also work with double ring (size 2 in this example):
