Skip to content

refactor: address code review feedback

bb8bab1
Select commit
Loading
Failed to load commit list.
Merged

feat: add native JSON output (-J/-j flags) #353

refactor: address code review feedback
bb8bab1
Select commit
Loading
Failed to load commit list.
Cirrus CI / main freebsd_instance:family/freebsd-14-3 failed Mar 12, 2026 in 6m 44s

Task Summary

Instruction autotools_test failed in 00:35

Details

✅ 00:02 clone
✅ 00:13 install
✅ 04:51 kernel_src
✅ 00:05 build
✅ 00:34 test
✅ 00:17 autotools_build
❌ 00:35 autotools_test

      |      ^
2 warnings generated.
mv -f tests/.deps/LTunix-LTlib.Tpo tests/.deps/LTunix-LTlib.Po
/bin/sh ./libtool  --tag=CC    --mode=link cc -DLT_BIGF -DLT_DEV64 -DLT_DIAL_freebsd -DLT_VERS=14000 -DLT_DEF_LSOF_PATH=\"/tmp/cirrus-ci-build/lsof\" -I./include  -g -O2 -DFREEBSDV=14000 -DHASPROCFS -DLSOF_VSTR=\"14.3-RELEASE\" -DHAS_LOCKF_ENTRY -DHASEFFNLINK=i_effnlink -DHASPSEUDOFS -I/usr/src/sys  -lutil -o tests/LTunix tests/LTunix-LTunix.o  tests/LTunix-LTlib.o  -lkvm
libtool: link: cc -DLT_BIGF -DLT_DEV64 -DLT_DIAL_freebsd -DLT_VERS=14000 -DLT_DEF_LSOF_PATH=\"/tmp/cirrus-ci-build/lsof\" -I./include -g -O2 -DFREEBSDV=14000 -DHASPROCFS -DLSOF_VSTR=\"14.3-RELEASE\" -DHAS_LOCKF_ENTRY -DHASEFFNLINK=i_effnlink -DHASPSEUDOFS -I/usr/src/sys -o tests/LTunix tests/LTunix-LTunix.o tests/LTunix-LTlib.o  -lutil -lkvm
cc -DHAVE_CONFIG_H -I.    -I./include -g -O2 -DFREEBSDV=14000 -DHASPROCFS -DLSOF_VSTR=\"14.3-RELEASE\" -DHAS_LOCKF_ENTRY -DHASEFFNLINK=i_effnlink -DHASPSEUDOFS -I/usr/src/sys -MT tests/LTbasic2-LTbasic2.o -MD -MP -MF tests/.deps/LTbasic2-LTbasic2.Tpo -c -o tests/LTbasic2-LTbasic2.o `test -f 'tests/LTbasic2.c' || echo './'`tests/LTbasic2.c
mv -f tests/.deps/LTbasic2-LTbasic2.Tpo tests/.deps/LTbasic2-LTbasic2.Po
/bin/sh ./libtool  --tag=CC    --mode=link cc  -I./include -g -O2 -DFREEBSDV=14000 -DHASPROCFS -DLSOF_VSTR=\"14.3-RELEASE\" -DHAS_LOCKF_ENTRY -DHASEFFNLINK=i_effnlink -DHASPSEUDOFS -I/usr/src/sys  -lutil -o  tests/LTbasic2 tests/LTbasic2-LTbasic2.o liblsof.la -lkvm
libtool: link: cc -I./include -g -O2 -DFREEBSDV=14000 -DHASPROCFS -DLSOF_VSTR=\"14.3-RELEASE\" -DHAS_LOCKF_ENTRY -DHASEFFNLINK=i_effnlink -DHASPSEUDOFS -I/usr/src/sys -o tests/.libs/LTbasic2 tests/LTbasic2-LTbasic2.o  ./.libs/liblsof.so -lutil -lkvm -Wl,-rpath -Wl,/usr/local/lib
make  check-TESTS
PASS: tests/case-00-hello.bash
PASS: tests/case-01-version.bash
PASS: tests/case-20-exit-status.bash
PASS: tests/case-20-fd-only-inclusion.bash
PASS: tests/case-20-handle-missing-files.bash
PASS: tests/case-20-offset-field.bash
PASS: tests/case-20-repeat-count.bash
PASS: tests/case-21-exit-Q-status.bash
PASS: tests/case-22-empty-process-name.bash
PASS: tests/case-30-json-output.bash
PASS: tests/case-31-jsonl-output.bash
PASS: tests/LTbasic
PASS: tests/LTbigf
PASS: tests/LTdnlc
PASS: tests/LTlock
SKIP: tests/LTnfs
PASS: tests/LTnlink
PASS: tests/LTsock
PASS: tests/LTszoff
PASS: tests/LTunix
FAIL: tests/LTbasic2
============================================================================
Testsuite summary for lsof 4.99.6
============================================================================
# TOTAL: 21
# PASS:  19
# SKIP:  1
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log for debugging.
============================================================================
*** Error code 1

Stop.
make[2]: stopped in /tmp/cirrus-ci-build
*** Error code 1

Stop.
make[1]: stopped in /tmp/cirrus-ci-build
*** Error code 1

Stop.
make: stopped in /tmp/cirrus-ci-build