feat: implement Inlay Hint capabilities #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements LSP 3.17 Inlay Hint capabilities, adding support for both client-to-server requests to fetch inlay hints and server-to-client refresh requests.
Key changes:
- Added
textDocument/inlayHintandinlayHint/resolverequest capabilities with concurrent resolution support - Implemented
workspace/inlayHint/refreshserver request handling - Provided a helper method
get_inlay_hint_labelfor convenient label extraction from hints
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/lsp_client/capability/request/inlay_hint.py |
Implements the main inlay hint request capability with support for fetching hints from a range and optionally resolving them concurrently, plus a helper to extract labels |
src/lsp_client/capability/request/__init__.py |
Exports the new WithRequestInlayHint capability class |
src/lsp_client/capability/server_request/inlay_hint_refresh.py |
Implements handling for server-initiated inlay hint refresh requests |
src/lsp_client/capability/server_request/__init__.py |
Exports the new WithRespondInlayHintRefresh capability class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| async def request_inlay_hint( | ||
| self, | ||
| file_path: AnyPath, | ||
| range: lsp_type.Range, |
There was a problem hiding this comment.
Inconsistent import style: this file uses lsp_type.Range directly, while similar capability files like inline_value.py import Range from lsp_client.utils.types and use it without the prefix. For consistency with the codebase, consider importing Range directly and using it as range: Range.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
textDocument/inlayHintwith concurrent resolve support.workspace/inlayHint/refreshserver-to-client request.get_inlay_hint_labelhelper for easy label extraction.