(Puppetfile) Switch to our tomcat fork for dependencies #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badenerb
requested review from
csilva-cl,
dtapiacl,
gseriche,
hstockeb,
igonzalezcl,
jhoblitt and
julioconstanzo
badenerb
force-pushed
the
IT-6481-Tomcat
branch
2 times, most recently
from
58b8730 to
c6a4c77
Compare
jhoblitt
requested changes
Nov 13, 2025
Member
jhoblitt
left a comment
jhoblitt
left a comment
There was a problem hiding this comment.
The PR title doesn't state what is being changed to a fork
badenerb
changed the title
badenerb
force-pushed
the
IT-6481-Tomcat
branch
from
c6a4c77 to
2634a67
Compare
jhoblitt
changed the title
jhoblitt
requested changes
Nov 13, 2025
Member
jhoblitt
left a comment
jhoblitt
left a comment
There was a problem hiding this comment.
s/dependancies/dependencies/
Also, adding a link to the upstream PR as a comment in the Puppetfile would be appreciated.
badenerb
force-pushed
the
IT-6481-Tomcat
branch
from
2634a67 to
38644e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for the official tomcat to approve/merge my PR here: puppetlabs/puppetlabs-tomcat#581