Open
Conversation
…user query to continue.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
hdrass
approved these changes
Dec 11, 2023
Contributor
hdrass
left a comment
hdrass
left a comment
There was a problem hiding this comment.
Thanks, Luca! Looks good!
Collaborator
Author
|
Please @teweitsai check the LVV-1782 test script and test it to the TTS, since I don't have access yet. |
Collaborator
gabrirod86
requested changes
Jul 17, 2024
Collaborator
gabrirod86
left a comment
gabrirod86
left a comment
There was a problem hiding this comment.
Please add the 3 missing cases for the angular coordinates, thanks!
gabrirod86
approved these changes
Jul 17, 2024
Collaborator
gabrirod86
left a comment
gabrirod86
left a comment
There was a problem hiding this comment.
Thanks for updating the code, the code has been tested on the TTS successfully for all the 6 DoFs.
gabrirod86
approved these changes
Jul 19, 2024
Collaborator
gabrirod86
left a comment
gabrirod86
left a comment
There was a problem hiding this comment.
Thanks for updating the units of measurement, the microrad was the unit of the M2 GUI, the CSC RBM commands work in arcsec, now the inconsistency has been cleared out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constrain on max displacement and user query to continue.