SITCOM-1081 - Update tech note with inertia compensation system initial analysis#7
Open
SITCOM-1081 - Update tech note with inertia compensation system initial analysis#7
Conversation
b1quint
force-pushed
the
tickets/SITCOM-1081
branch
2 times, most recently
from
b126187 to
c90c914
Compare
We want the format in this tech note to be consistently in markdown. It did not make sense to keep the readme in RST format.
b1quint
force-pushed
the
tickets/SITCOM-1081
branch
from
c90c914 to
5a7783c
Compare
…em and ComCam on Sky Campaign
Adding the documentation for the Single Slew Analysis section
Change in the last paragraph of the single slew section
Single Slew Analysis move to markdown format
Text Histogram Analysis
dsanmartim
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Hi Paulina. Thanks for putting things together.
I've left just a few comments directly in the changed files. As a more general suggestion, I think this technote would fit quite well (at least partially, if not entirely) with the technote template available here: sitcomtn-102.
Thanks again!
check of Text Style: indentation and sentence per lines
idem
idem 2
Images added - Histogram and HP
idem
image position
idem
idem
idem
idem
inertia impact --> inertial forces inertia effects --> inertial effects
Figure caption added.
markdown caption make-up
markdown make-up
idem
solving Captions issue
paragraph rephrased. / "The limits of Hardpoints do...
Contributor
|
Thanks @dsanmartim , your comments were accepted and te document is reviewed, any extra comment please don't hesitate to let me know. :) |
dsanmartim
approved these changes
Mar 18, 2025
dsanmartim
left a comment
dsanmartim
left a comment
There was a problem hiding this comment.
Hi Paulina. Thanks for the changes. It is approved. One thing to keep in mind: this is a good document to be adapted to follow the technotes template.
b1quint
commented
Mar 25, 2025
Because this change is affecting the main concept, a branch has been opened.
correction of the breakaway concept
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the spirit of trying to catch up on this tech note, we need to write all the analyses associated with the inertia compensation system. We use the hardpoints minimum and maximum values during a slew and compare with the breakaway, fatigue, and operational limits. Let's explain that and follow the check-boxes in SITCOM-1081.