DM-46527: Add client methods for waiting for data to land in ConsDB #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
force-pushed
the
tickets/DM-46527
branch
from
06dc9f8 to
a83fd44
Compare
mfisherlevine
force-pushed
the
tickets/DM-46527
branch
2 times, most recently
from
0cae013 to
9c59b2b
Compare
mfisherlevine
force-pushed
the
tickets/DM-46527
branch
from
9c59b2b to
019c56e
Compare
mfisherlevine
force-pushed
the
tickets/DM-46527
branch
4 times, most recently
from
f1d61fd to
f09dc2e
Compare
| raise ValueError(f"Query {query} returned more than one row") | ||
| assert len(result) == 1, "Somehow no rows came back, which should be impossible" | ||
| row = result[0] | ||
| if item not in row.columns: |
Collaborator
There was a problem hiding this comment.
I wasn't sure what you meant by "item" (in the doc string and method name) until I got to this row. In a relational database, the intersection of a column and a row is sometimes called a "field" and the contents are the field value. Sometimes a column itself is called a "field" (or "attribute"). You could probably go with "value", "field value", "field."
From what I can tell the input parameter is "column"/"attribute" flavored and the return is a "field"/"value"/"fieldValue" flavored.
mfisherlevine
force-pushed
the
tickets/DM-46527
branch
from
f09dc2e to
9d54bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.