DM-49673: Make spatialOrder config in piff per-band and add a minNPsfStar criterion for detector rejection#501
Closed
DM-49673: Make spatialOrder config in piff per-band and add a minNPsfStar criterion for detector rejection#501
Conversation
laurenam
force-pushed
the
tickets/DM-49673
branch
from
1dc8c04 to
7f4d1d0
Compare
laurenam
changed the title
PFLeget
reviewed
Mar 25, 2025
config/finalize_characterization.py
Outdated
| @@ -0,0 +1 @@ | |||
| config.psf_determiner['piff'].spatialOrderPerBand = {"fallbadk": 2} | |||
There was a problem hiding this comment.
there is a typo:
Suggested change
| config.psf_determiner['piff'].spatialOrderPerBand = {"fallbadk": 2} | |
| config.psf_determiner['piff'].spatialOrderPerBand = {"fallback": 2} |
Contributor
Author
There was a problem hiding this comment.
Good catch! Fixed and checked:
$ pipetask build -p $DRP_PIPE_DIR/pipelines/HSC/DRP-RC2.yaml#finalizeCharacterizationDetector --show config="*piff*patialOr*"
Matching "*piff*patialOr*" without regard to case (append :NOIGNORECASE to prevent this)
### Configuration for task `finalizeCharacterizationDetector'
# Per-band spatial order for PSF kernel creation. Ignored if piffPsfConfigYaml is set.
config.psf_determiner['piff'].spatialOrderPerBand={'fallback': 2}
And it also prompted me to add the check for this field in the config validation in meas_extensions_piff 😅
PFLeget
approved these changes
Mar 25, 2025
This is to maintain current behavior.
laurenam
force-pushed
the
tickets/DM-49673
branch
from
7f4d1d0 to
675586a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.