-
Notifications
You must be signed in to change notification settings - Fork 4
Show slide position in seek-slider yellow strip #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: lstein <[email protected]>
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot The slider-hover-strip should update when the slide position is set using the seek-slider. Currently it does not.
Co-authored-by: lstein <[email protected]>
Fixed in b3a1224. The hover strip now updates when:
Modified |
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Looks very good. Three minor aesthetic change requests:
- Make the left-hand side of the seek slider widget yellow rather than dark gray currently used. This will ensure visual consistency between the hoverStrip and the slider.
- When pulling down the seek slider there is an intermediate vertical position of the mouse cursor that causes the slider to jitter up and down. It's possibly caused by two competing events. Could you figure out what's causing this and fix it?
- The right end of the hoverStrip is slightly farther to the right than the right end of the seek slider. Please make the hoverStrip and the seek slider colinear.
Co-authored-by: lstein <[email protected]>
Fixed in 367c2db:
Also added CSS custom properties ( |
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jittering is not completely fixed, but much better. Other issues addressed to my satisfaction.
This PR implements a UI improvement that shows the current slide position on the
sliderHoverStripelement using a two-color gradient:The hover strip now updates in real-time when the user drags the seek-slider, not just when the slide changes.
Additional Improvements
--slider-progress-colorand--slider-remaining-colorvariables for easier color maintenanceOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.