-
Notifications
You must be signed in to change notification settings - Fork 4
Enhance UMAP search result highlighting with larger markers, white borders, and persistent settings #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and clear link Co-authored-by: lstein <[email protected]>
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use solid colored points, not circles in the plotly graph. I would like the appearance of the umap plot to be similar to its appearance in the current master branch.
Co-authored-by: lstein <[email protected]>
Added explicit |
|
@copilot No, something is not right. The points are still displaying as small hollow circles rather than solid circles. |
Co-authored-by: lstein <[email protected]>
Fixed by setting |
|
@copilot Please make the umap "Show landmarks" and "Show hover thumbnails" checkboxes persistent across sessions by saving to local storage in state.js. Be aware that before the checkboxes are initialized, the state in state.js needs to fully load. |
…calStorage Co-authored-by: lstein <[email protected]>
Implemented persistent checkbox settings for "Show landmarks" and "Show hover thumbnails". The states are now saved to localStorage and restored on page load. The initialization waits for the stateReady event to ensure state is fully loaded before setting checkbox values. (3efc389) |
|
@copilot Please add a new checkbox to the umap window labeled "Exit fullscreen on selection". Place it between "Show hover thumbnails" and "Highlight selection". When selected (the initial default), clicking on a point in the umap should select the current cluster and exit umap fullscreen mode. If unselected, the umap window size should not change when a point is clicked. The state of this checkbox should be stored in persistent LocalStorage, the same way that the other checkboxes in this window are stored. The checkbox and its label should only be enabled when the umap window is in fullscreen mode. |
…torage Co-authored-by: lstein <[email protected]>
…pecified Co-authored-by: lstein <[email protected]>
Implemented "Exit fullscreen on selection" checkbox between "Show hover thumbnails" and "Highlight selection". The checkbox:
Also fixed highlighted points to use bright yellow (#faea0e) and size 8 as specified. (ae12822) |
|
@copilot A couple of requests: |
|
@copilot A couple of requests:
|
…rease window height Co-authored-by: lstein <[email protected]>
Completed both requests:
|
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Successfully implemented UMAP highlighting improvements with all feedback addressed:
Changes Made
1. Enhanced Visual Highlighting
Selected image spots in the UMAP are now:
Non-selected spots are dimmed (opacity 0.2 for unclustered, 0.75 for clustered) to emphasize the selection.
2. Clear Link Added
A blue clickable "clear" link appears next to the "Highlight selection" checkbox, providing quick access to clear search results without navigating to the search panel.
3. Persistent UMAP Settings
The "Show landmarks", "Show hover thumbnails", and "Exit fullscreen on selection" checkbox states are now persistent across browser sessions:
setUmapShowLandmarks(),setUmapShowHoverThumbnails(), andsetUmapExitFullscreenOnSelection())4. Exit Fullscreen on Selection Checkbox
Added a new "Exit fullscreen on selection" checkbox positioned between "Show hover thumbnails" and "Highlight selection":
5. Increased Window Height
UMAP window sizes have been increased to provide more breathing room for the checkboxes:
This prevents the "Highlight selection" option from abutting the bottom of the window.
Testing
The changes improve user experience by making search results more visible in the UMAP visualization through enlarged markers with white borders, providing user control over fullscreen behavior, and preserving user preferences across sessions.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.