Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 25, 2025

PR #170 added two radio buttons to the UMAP controls section, increasing its height. In fullscreen mode, the plot now overlaps the ControlPanel and SearchPanel at the bottom of the screen.

Changes

  • Increased controlsHeight from 180px to 230px in setUmapWindowSize()
  • Added inline comment documenting the height allocation:
    • ~120px for UMAP controls (EPS spinner + 2 radio buttons + 4 checkboxes)
    • ~110px clearance for bottom panels
// Before
const controlsHeight = 180;

// After  
// controlsHeight: space reserved below plot for UMAP controls (~120px with radio buttons)
// plus clearance for bottom ControlPanel/SearchPanel (~110px)
const controlsHeight = 230;

The calculation plotDiv.style.height = window.innerHeight - controlsHeight now leaves adequate space below the plot for both the UMAP controls and the fixed bottom panels.

Narrow screens (≤600px) use a different layout and are unaffected.

Original prompt

This section details on the original issue you should resolve

<issue_title>Prevent full-screen umap window from overlapping with ControlPanel element</issue_title>
<issue_description>The most recent commits added two stacked radio buttons to the umap window. Unfortunately this causes the window to increase in height and makes it partially overlap the ControlPanel and SearchPanel elements. Please recalculate the height of the umap window so that there is no overlap with these two elements when it is in full-screen mode.</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Prevent umap window from overlapping with ControlPanel Increase UMAP fullscreen controlsHeight to prevent overlap with bottom panels Dec 25, 2025
Copilot AI requested a review from lstein December 25, 2025 16:33
@lstein lstein marked this pull request as ready for review December 25, 2025 16:38
@lstein lstein merged commit edb5ce3 into master Dec 26, 2025
4 checks passed
@lstein lstein deleted the copilot/fix-umap-overlap-controlpanel branch January 4, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent full-screen umap window from overlapping with ControlPanel element

2 participants