Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 26, 2025

When "Exit full screen on selection" and "Click selects image" are both enabled, clicking an image in the umap window did not exit fullscreen mode as expected.

Changes

Added fullscreen exit logic to handleImageClick() to match the existing behavior in handleClusterClick():

async function handleImageClick(clickedIndex) {
  const clickedPoint = points.find((p) => p.index === clickedIndex);
  if (!clickedPoint) return;

  exitSearchMode();
  slideState.navigateToIndex(clickedIndex, false);
  
  // Exit fullscreen mode if enabled
  if (isFullscreen && state.umapExitFullscreenOnSelection) {
    setTimeout(() => toggleFullscreen(false), 100);
  }
}

The cluster selection path already triggered fullscreen exit via the searchResultsChanged event handler. Image selection now behaves consistently using the same 100ms delay to avoid flicker.

Original prompt

This section details on the original issue you should resolve

<issue_title>Exit umap full-screen mode when click-to-navigate is active</issue_title>
<issue_description>In the umap window, when “Exit full screen on selection” and “Click selects image” are both selected, the umap window should exit full screen mode. Currently it does not.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix umap not exiting full-screen mode when click-to-navigate is active Fix umap fullscreen exit when click-to-navigate is active Dec 26, 2025
Copilot AI requested a review from lstein December 26, 2025 13:12
Copy link
Owner

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix

@lstein lstein marked this pull request as ready for review December 26, 2025 13:39
@lstein lstein merged commit 3e72d26 into master Dec 26, 2025
4 checks passed
@lstein lstein deleted the copilot/fix-exit-fullscreen-umap branch January 4, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exit umap full-screen mode when click-to-navigate is active

2 participants