-
Notifications
You must be signed in to change notification settings - Fork 4
Allow multiple albums in --album-locked option #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: lstein <[email protected]>
Co-authored-by: lstein <[email protected]>
Co-authored-by: lstein <[email protected]>
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the list of albums passed to --album-locked includes an album key that is not in the configuration file, then the command should fail with a suitable error message. The server should not run.
- Validate that all albums specified in --album-locked exist in configuration - Exit with error code 1 and helpful message if invalid albums are specified - Exit with error code 1 if no albums are configured but --album-locked is used - Add test for validation logic Co-authored-by: lstein <[email protected]>
Implemented in commit 6e68989. The server now validates all album keys specified in
Example error output: |
Co-authored-by: lstein <[email protected]>
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The
--album-lockedoption previously restricted to a single album, hiding the album selector entirely. This enhancement allows specifying multiple albums while maintaining security restrictions.Changes
Argument parsing (
args.py)--album-lockedto accept multiple arguments vianargs='+'Backend logic (
routers/album.py,photomap_server.py)get_locked_albums()helper to parse locked album listcheck_album_lock()to validate against album list/available_albums/to return only locked albums when restrictedalbumparameter against locked list--album-lockedis usedFrontend (
templates/modules/settings.html)Behavior:
All filesystem operations, album management, and export functions remain disabled when any album lock is active.
Testing:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.