chore: update deploy actions #190
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the deployment workflow to add release tagging automation and improve artifact uploading by passing tag information between jobs.
- Added job outputs to the
tag-releasejob to expose version and tag information to downstream jobs - Implemented tag existence checking to prevent duplicate tags from being created
- Modified the
upload-releasejob to accept and use the tag name from thetag-releasejob
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
.github/workflows/deploy.yml |
Added outputs to tag-release job, implemented tag existence check, added conditional tagging, and passed tag to upload-release job |
.github/workflows/upload-artifacts.yml |
Added tag_name input parameter and configured artifact upload to use the provided tag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/deploy.yml
Outdated
| - name: Check if tag exists | ||
| id: check_tag | ||
| run: | | ||
| if git ls-remote --tags origin | grep -q "refs/tags/v${{ steps.get_version.outputs. version }}"; then |
There was a problem hiding this comment.
There's a typo in the variable reference. There's an extra space between "steps.get_version.outputs." and "version". This should be "steps.get_version.outputs.version" without the extra space.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
@copilot Please repeat your review of this code to ensure that it is syntactically and semantically correct. |
This pull request updates the deployment workflow to improve release tagging and artifact uploading automation. The main changes ensure that releases are consistently tagged, prevent duplicate tags, and pass the tag name through the workflow for artifact uploads.
Release Tagging Improvements
tag-releasejob, and to check if the tag already exists before creating a new one, preventing duplicate tags. (.github/workflows/deploy.yml) [1] [2]Artifact Upload Automation
upload-releasejob to depend on thetag-releasejob and to pass the generated tag name as an input to the artifact upload workflow, ensuring artifacts are correctly attached to the release tag. (.github/workflows/deploy.yml,.github/workflows/upload-artifacts.yml) [1] [2]tag_nameinput when uploading release artifacts, ensuring they are associated with the correct release tag. (.github/workflows/upload-artifacts.yml)