[Bugfix] Fix pyinstallers #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the PyInstaller build scripts to consistently use the
--onedirmode for all builds, including CPU variants, to address issues with large packages like torch. It also improves the macOS launcher script to reliably locate the binary using its directory path.Build process improvements:
INSTALL/pyinstaller/make_pyinstaller_image.ps1: Changed logic to always use--onedirmode for PyInstaller builds, regardless of the torch variant, due to problems with--onefileand large packages.INSTALL/pyinstaller/make_pyinstaller_image.sh: Updated to always use--onedirfor CPU builds, commenting out previous logic that used--onefilefor CPUs.macOS launcher reliability:
INSTALL/pyinstaller/make_pyinstaller_image.sh: Modified the macOS launcher script to use the directory of the script ($PWD) when launching the binary, ensuring correct path resolution.