Skip to content

Manage empty lockoutDate in isLocked function #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coudot merged 2 commits into from
Nov 28, 2025
Merged

Manage empty lockoutDate in isLocked function #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92be58d
Unit test for isLocked and no lockout duration
coudot Nov 28, 2025
9592788
If no lockout duration and lockout date, account is locked
coudot Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Ltb/Directory/OpenLDAP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ public function isLocked($entry, $pwdPolicyConfiguration) : bool {

$unlockDate = $this->getUnlockDate($entry, $pwdPolicyConfiguration);

if (!$unlockDate) {
return true;
}

if ( $unlockDate and time() <= $unlockDate->getTimestamp() ) {
return true;
}
Expand Down
26 changes: 26 additions & 0 deletions tests/Ltb/DirectoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,32 @@ public function test_openldap_islocked_no_more_locked(): void
$this->assertFalse($isLocked, "Account should no more be locked");
}

public function test_openldap_islocked_lockout_duration_zero(): void
{
$entry = [
'pwdaccountlockedtime' => [
'count' => 1,
0 => (new DateTime)->modify("-10 days")->format("Ymdhis\Z")
]
];

$isLocked = (new Ltb\Directory\OpenLDAP)->isLocked($entry, array('lockout_duration' => 0));
$this->assertTrue($isLocked, "Account should be locked");
}

public function test_openldap_islocked_no_lockout_duration(): void
{
$entry = [
'pwdaccountlockedtime' => [
'count' => 1,
0 => (new DateTime)->modify("-10 days")->format("Ymdhis\Z")
]
];

$isLocked = (new Ltb\Directory\OpenLDAP)->isLocked($entry, array('lockout_duration' => null));
$this->assertTrue($isLocked, "Account should be locked");
}

public function test_openldap_getlockdate_empty(): void
{
$entry = [
Expand Down