Skip to content

Manage lock date in future #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coudot merged 2 commits into from
Nov 28, 2025
Merged

Manage lock date in future #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32fe331
Unit test for lock in future
coudot Nov 28, 2025
f4c2dba
Manage lock date in future
coudot Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Ltb/Directory/OpenLDAP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ public function isLocked($entry, $pwdPolicyConfiguration) : bool {
return true;
}

if ( $this->getLockDate($entry, $pwdPolicyConfiguration)->getTimestamp() > time() ) {
return false;
}

$unlockDate = $this->getUnlockDate($entry, $pwdPolicyConfiguration);

if (!$unlockDate) {
Expand Down
13 changes: 13 additions & 0 deletions tests/Ltb/DirectoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,19 @@ public function test_openldap_islocked_lockout_disabled(): void
$this->assertFalse($isLocked, "Account should not be locked");
}

public function test_openldap_islocked_lockdate_in_future(): void
{
$entry = [
'pwdaccountlockedtime' => [
'count' => 1,
0 => (new DateTime)->modify("+10 days")->format("Ymdhis\Z")
]
];

$isLocked = (new Ltb\Directory\OpenLDAP)->isLocked($entry, array('lockout_duration' => 86400, 'lockout_enabled' => true));
$this->assertFalse($isLocked, "Account should not be locked");
}

public function test_openldap_getlockdate_empty(): void
{
$entry = [
Expand Down