Two small fixes (nodes image list to image batch, wildcard prompt from string) #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jkrauss82
commented
Jun 15, 2024
jkrauss82
commented
- make sure image list is always converted to batch
- fix check on variable in wildcard prompt from string node
…ble in wildcard prompt from string node
ltdrdata
requested changes
Jun 26, 2024
| if restrict_to_tags is None: restrict_to_tags = "" | ||
| if exclude_tags is None: exclude_tags = "" | ||
| if not isinstance(restrict_to_tags, list): | ||
| if restrict_to_tags is not None and restrict_to_tags != "" and not isinstance(restrict_to_tags, list): |
Owner
There was a problem hiding this comment.
restrict_to_tags is always string and not a optional input.
So you can remove
None check of restrict_to_tags and isinstance(restrict_to_tags, list)
if restrict_to_tags != "":
restrict_to_tags = restrict_to_tags.split(", ")
else:
restrict_to_tags = []
| x = x.split(", ") | ||
| # restrict to tags | ||
| if restrict_to_tags != "": | ||
| if isinstance(restrict_to_tags, list): |
Owner
There was a problem hiding this comment.
We can assume restrict_to_tags is always a list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.