feat: Add upscaled and upscaled_refined outputs to DetailerDebug nodes for more debugging capability
#937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a third tuple member, `refined_upscaled_image` is returned in addition to `refined_image` - some variables are given longer and more specific names to make the code easier to follow - as this member is added as a last member of the tuple, this is not a breaking change
- this is an additional output for DetailerForEachTest and DetailerForEachTestPipe - the motivation is to be able to see the enhanced/refined image in its full resolution
…rEach - introduced `unenhanced_upscaled_image` as an additional output from `enhance_detail` to provide access to the unrefined upscaled image. - updated `DetailerForEach` and `DetailerForEachTest` to accommodate the new output, ensuring consistency in image processing. - modified variable names for clarity and improved code readability.
mbylstra
changed the title
upscaled and upscaled_refined outputs to DetailerDebug nodes for more debugging capability
mbylstra
changed the title
upscaled and upscaled_refined outputs to DetailerDebug nodes for more debugging capabilityupscaled and upscaled_refined outputs to DetailerDebug nodes for more debugging capability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a placeholder for now. I still need to do more testing. It adds two extra outputs to the "DetailerDebug (SEGS)" and "DetailerDebug (SEGS/pipe)" nodes:
upscaledupscaled_refinedThese are similar to
croppedandcropped_refinedbut they show the full upscaled image before and after it is refined at full resolution, and before it is downscaled to original size.Example in use locally:
In the example I intentionally used an unrealistically high denoise value, to demonstrate that that the face is being generated at high resolution under the hood (this is not very clear from the documentation, and there was no way to see what was going on under the hood at high resolution)