-
Notifications
You must be signed in to change notification settings - Fork 48
Add GitHub Actions workflow for building modules #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Should the workflow also try to load the kernel module after building just for a better check ? |
This would be bordering tests domain IMO |
I feel like, they are not required. This catches most of missed cases (which is rare), XD.. |
e9076bf to
7ee7ba8
Compare
|
hey @sheharyaar @carloslack, do you think we can merge this or do you still have open concerns? |
LGTM, we can merge this. |
Ack; will merge it after releasing 4.0 |
|
I guess this fixes #309. |
See:
https://github.com/Physic69/lunatik/pulls
for working