Skip to content

Conversation

@Physic69
Copy link
Contributor

@Physic69 Physic69 commented Dec 28, 2025

@Physic69 Physic69 marked this pull request as ready for review December 28, 2025 20:57
@sheharyaar
Copy link
Member

Should the workflow also try to load the kernel module after building just for a better check ?

@carloslack
Copy link
Collaborator

Should the workflow also try to load the kernel module after building just for a better check ?

This would be bordering tests domain IMO

@Physic69
Copy link
Contributor Author

Physic69 commented Dec 29, 2025

Should the workflow also try to load the kernel module after building just for a better check ?

I feel like, they are not required. This catches most of missed cases (which is rare), XD..
Also added 5.x kernel version as well, as per issue stated 5.x onwards..

@Physic69 Physic69 force-pushed the workflow branch 2 times, most recently from e9076bf to 7ee7ba8 Compare December 29, 2025 21:23
@Physic69 Physic69 requested a review from carloslack January 1, 2026 20:30
@lneto
Copy link
Contributor

lneto commented Jan 16, 2026

hey @sheharyaar @carloslack, do you think we can merge this or do you still have open concerns?

@sheharyaar
Copy link
Member

hey @sheharyaar @carloslack, do you think we can merge this or do you still have open concerns?

LGTM, we can merge this.

@lneto
Copy link
Contributor

lneto commented Jan 17, 2026

hey @sheharyaar @carloslack, do you think we can merge this or do you still have open concerns?

LGTM, we can merge this.

Ack; will merge it after releasing 4.0

@sheharyaar
Copy link
Member

I guess this fixes #309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants