Open
Conversation
Contributor
|
This is amazing! I tried compiling it to see what problems I could fix, and adding |
f2eaaa5 to
af0b0dd
Compare
Member
|
I would prefer to first merge the custom scrollbar code back to the Irrlicht part to deduplicate lots of code. This has been on my TODO list for a while but it seems it's now time to do it. |
appgurueu
reviewed
Mar 31, 2026
appgurueu
reviewed
Mar 31, 2026
appgurueu
reviewed
Mar 31, 2026
af0b0dd to
937473a
Compare
937473a to
c6c48c2
Compare
c6c48c2 to
3ed6e7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
styleandstyle_typerules can now affect scrollbars in more ways than justnoclip. GUIScrollBar is modified to reflect styling properties, and various formspec element classes are modified to pass styling information to their implicit scrollbars. All style properties used by scrollbars are defined already, so there is no change in that regard.To do
This PR is ready for review.
A few questions to consider:
up/downgood names for the scrollbar buttons?fgimgwithout anfgimg_middleimplicitly causescrollbaroptions[thumbsize=0]?How to test
Create and load a mod with the following code in MTG, then run
/scrollbardemo: