Skip to content

Add option to silence HTTP errors - Rebased/adopted PR #12972#17076

Merged
SmallJoker merged 1 commit intoluanti-org:masterfrom
sofar:sofar/12972
Apr 1, 2026
Merged

Add option to silence HTTP errors - Rebased/adopted PR #12972#17076
SmallJoker merged 1 commit intoluanti-org:masterfrom
sofar:sofar/12972

Conversation

@sofar
Copy link
Copy Markdown
Contributor

@sofar sofar commented Mar 31, 2026

This adopts PR #12972

All I did was rebase it on master, and run unittests.

Reason why I'm adopting it is because in the process of experimenting with the skins concept, I had the need for this exact functionality, and wrote a less good implementation than this one. So, it bears to say that TurkeyMcMac's version should be merged with credit to him.

Copy link
Copy Markdown
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zughy Zughy added One approval ✅ ◻️ @ Script API Feature ✨ PRs that add or enhance a feature Roadmap: supported by core dev PR not adhering to the roadmap, yet some core dev decided to take care of it labels Mar 31, 2026
@sfan5 sfan5 added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Mar 31, 2026
@sofar sofar requested a review from sfan5 April 1, 2026 00:19
@appgurueu appgurueu added >= Two approvals ✅ ✅ and removed One approval ✅ ◻️ Action / change needed Code still needs changes (PR) / more information requested (Issues) labels Apr 1, 2026
@SmallJoker SmallJoker merged commit 82149c3 into luanti-org:master Apr 1, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature ✨ PRs that add or enhance a feature Roadmap: supported by core dev PR not adhering to the roadmap, yet some core dev decided to take care of it @ Script API >= Two approvals ✅ ✅

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants