beds: allow setting spawn point during daytime

[GP-commits]

Summary

Allow players to set their spawn point by right-clicking a bed during daytime.

Changes

• Set spawn point on right-click even during daytime
• Kept existing night sleep behavior unchanged

Motivation

Improves convenience without affecting existing mechanics.

Closes #3151

[GP-commits]

Hi, the workflows are awaiting approval. Could you please approve them so checks can run?

[ssdaniel24]

Seems like if i will spam clicking on bed at the day, it will write in the chat:

You can only sleep at night.
Spawn point set.
You can only sleep at night.
Spawn point set.
You can only sleep at night.
Spawn point set.
...

I think you should add check for already set spawnpoint.

[GP-commits]

Good catch, thanks! I’ll add a check to prevent repeated spawn setting.

[SmallJoker]

Please indent the entire new code block so that it makes sense again.

[SmallJoker]

How about else instead? Have the first click set the spawn point and the 2nd to notify the player that it's yet not time to sleep.

[SmallJoker]

Hi, the workflows are awaiting approval.

FYI, running the checks locally is straight-forward. Install luacheck and give it the path to minetest_game to parse. Interestingly it does not catch indent (stylistic) issues.

[sfan5]

is this a documented API function? if so, won't this break compatibility?

[SmallJoker]

Same thought here. It's not documented, thus no compat break.

minetest_game/game_api.txt

Lines 41 to 57 in 95991f8

	Beds API
	--------
	beds.register_bed(
	"beds:bed", -- Bed name
	def -- See [#Bed definition]
	)
	* `beds.can_dig(bed_pos)` Returns a boolean whether the bed at `bed_pos` may be dug
	* `beds.read_spawns() ` Returns a table containing players respawn positions
	* `beds.kick_players()` Forces all players to leave bed
	* `beds.kick_player_at(pos)` Forces player out of bed at pos (returns true on success, false otherwise)
	* `beds.skip_night()` Sets world time to morning and saves respawn position of all players currently sleeping
	* `beds.day_interval` Is a table with keys "start" and "finish". Allows you
	to set the period of the day (timeofday format). Default: `{ start = 0.2, finish = 0.805 }`.
	### Bed definition