Add support for installing tl files#2
Open
FourierTransformer wants to merge 3 commits intoluarocks:masterfrom
Open
Add support for installing tl files#2FourierTransformer wants to merge 3 commits intoluarocks:masterfrom
FourierTransformer wants to merge 3 commits intoluarocks:masterfrom
Conversation
Remove TODO section about installing source files.
| if gen_target == "5.2" then | ||
| gen_target = "5.1" | ||
| -- should this just be a raw require? is there a safe luarocks loader for this instead? | ||
| local tlconfig = require("tlconfig") |
Author
There was a problem hiding this comment.
Not entirely sure if there's a better/safer way to handle the require. I'm not the most familiar with LuaRocks internals, but I did poke around a bit.
Turns out it was working for me since I already had the folder in place, but it was failing on fresh installs. This should resolve it. Also, after perusing the luarocks code I noticed that `make_dir` does return an error, so added that for better handling in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
tlconfig.luafileassert(rockspec:type() == "rockspec")as the warning thrown indicated it was no longer needed