Skip to content

Android / Blur Transformation: Fix leaked RenderScript objects #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Android / Blur Transformation: Fix leaked RenderScript objects #1562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a74f0df
Android / Blur: Prevent leak by explicitly calling 'Destroy' on alloc…
projectgoav Apr 8, 2022
033a9c7
Android / Blur: Remove old commented out code.
projectgoav Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions source/FFImageLoading.Transformations.Droid/BlurredTransformation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,22 +64,13 @@ public static Bitmap ToBlurred(Bitmap source, Context context, float radius)
script.ForEach(outAlloc);
outAlloc.CopyTo(output);

// NOTE: Xamarin.Android Dispose() doesn't call 'destroy' on the allocations or scripts. Therefore, we must manually call it.
outAlloc.Destroy();
inAlloc.Destroy();
script.Destroy();
rs.Destroy();
return output;
}

//Bitmap output = Bitmap.createBitmap(smallBitmap.getWidth(), smallBitmap.getHeight(), smallBitmap.getConfig());

//RenderScript rs = RenderScript.create(getContext());
//ScriptIntrinsicBlur script = ScriptIntrinsicBlur.create(rs, Element.U8_4(rs));
//Allocation inAlloc = Allocation.createFromBitmap(rs, smallBitmap, Allocation.MipmapControl.MIPMAP_NONE, Allocation.USAGE_GRAPHICS_TEXTURE);
//Allocation outAlloc = Allocation.createFromBitmap(rs, output);
//script.setRadius(BLUR_RADIUS);
//script.setInput(inAlloc);
//script.forEach(outAlloc);
//outAlloc.copyTo(output);

//rs.destroy();
}

return ToLegacyBlurred(source, context, (int)radius);
Expand Down