Merged
Conversation
This tweaks the file descriptor logic in order to avoid spurioous errors when there is a `$LISTEN_PID` mismatch, or when the variables are unset.
Kixunil
reviewed
Apr 4, 2025
src/activation.rs
Outdated
| .context("failed to parse LISTEN_PID")?; | ||
| let current_pid = process::id(); | ||
| if pid != current_pid { | ||
| log::warn!( |
There was a problem hiding this comment.
I think encountering this is not really broken, so warn seems too high severity to me. I'd use some lower severity with a message along the lines of "systemd activation environment is set but not meant for this process".
Basically, I'd treat it as pretty normal case but logging it still has value in case someone is debugging systemd itself.
Owner
Author
There was a problem hiding this comment.
Yes, this is mostly meant for debugging.
I've lowered the log level and reworded the message a bit.
Thanks for the feedback.
src/activation.rs
Outdated
| .context("failed to parse LISTEN_PID")?; | ||
| let current_pid = process::id(); | ||
| if pid != current_pid { | ||
| log::warn!( |
|
Looks good, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks the file descriptor logic in order to avoid spurious errors when there is a
$LISTEN_PIDmismatch, or when the variables are unset.Closes #155