-
Notifications
You must be signed in to change notification settings - Fork 1
🔇 Denoiser: Add rejected patterns to CONSISTENTLY_IGNORED.md #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucasew
wants to merge
3
commits into
main
Choose a base branch
from
denoiser/add-consistently-ignored-17306576171435659683
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
d3f475f
🔇 Denoiser: Add rejected patterns to CONSISTENTLY_IGNORED.md
google-labs-jules[bot] 083ea28
🛟 Arrumador: Fix CI failures and standard tooling
google-labs-jules[bot] db77ad8
🔇 Denoiser: Add rejected patterns to CONSISTENTLY_IGNORED.md
google-labs-jules[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,27 @@ | ||||||
| # Consistently Ignored Changes | ||||||
|
|
||||||
| This file lists patterns of changes that have been consistently rejected by human reviewers. All agents MUST consult this file before proposing a new change. If a planned change matches any pattern described below, it MUST be abandoned. | ||||||
|
|
||||||
| ## IGNORE: JSDoc Documentation Format | ||||||
|
|
||||||
| **- Pattern:** Using `/** ... */` JSDoc-style comments for Go code. | ||||||
| **- Justification:** Go code should use standard `//` comments for documentation to be compatible with `go doc` and idiomatic style. | ||||||
| **- Files Affected:** `*.go` | ||||||
|
|
||||||
| ## IGNORE: Header Sanitization via Del() | ||||||
|
|
||||||
| **- Pattern:** Relying on `http.Header.Del()` to remove non-canonical or malformed headers (e.g. underscore variations like `Tailscale_User_Login`) for security sanitization. | ||||||
| **- Justification:** `Header.Del()` canonicalizes keys and fails to remove non-canonical variations that might be present in the map. Use `delete(headerMap, key)` instead. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This justification is correct, but could be more explicit about why
Suggested change
|
||||||
| **- Files Affected:** `http.go` | ||||||
|
|
||||||
| ## IGNORE: Manual Context Cleanup | ||||||
|
|
||||||
| **- Pattern:** Manually calling `cancel()` on multiple error return paths in constructors or setup functions. | ||||||
| **- Justification:** Prone to errors if a path is missed. Use `defer func() { if err != nil { cancel() } }()` pattern instead. | ||||||
| **- Files Affected:** `*.go` | ||||||
|
|
||||||
| ## IGNORE: CI/CD Workflow Overhaul | ||||||
|
|
||||||
| **- Pattern:** Replacing the existing granular `autorelease.yml` workflow steps with a single `mise run ci` command, or removing `scorecard.yml`. | ||||||
| **- Justification:** The project prefers the existing granular workflow structure and `scorecard.yml` should be preserved. Large overhauls of the CI configuration are consistently rejected. | ||||||
| **- Files Affected:** `.github/workflows/*.yml`, `mise.toml` | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and standard Markdown structure, consider using a proper bulleted list for describing the pattern details. This makes the document easier to parse visually.
This formatting improvement should be applied consistently to all similar sections in this file (lines 13-15, 19-21, and 25-27).