Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .jules/CONSISTENTLY_IGNORED.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Consistently Ignored Changes

This file lists patterns of changes that have been consistently rejected by human reviewers. All agents MUST consult this file before proposing a new change. If a planned change matches any pattern described below, it MUST be abandoned.

## IGNORE: JSDoc Documentation Format

**- Pattern:** Using `/** ... */` JSDoc-style comments for Go code.
**- Justification:** Go code should use standard `//` comments for documentation to be compatible with `go doc` and idiomatic style.
**- Files Affected:** `*.go`
Comment on lines +7 to +9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and standard Markdown structure, consider using a proper bulleted list for describing the pattern details. This makes the document easier to parse visually.

This formatting improvement should be applied consistently to all similar sections in this file (lines 13-15, 19-21, and 25-27).

Suggested change
**- Pattern:** Using `/** ... */` JSDoc-style comments for Go code.
**- Justification:** Go code should use standard `//` comments for documentation to be compatible with `go doc` and idiomatic style.
**- Files Affected:** `*.go`
- **Pattern:** Using `/** ... */` JSDoc-style comments for Go code.
- **Justification:** Go code should use standard `//` comments for documentation to be compatible with `go doc` and idiomatic style.
- **Files Affected:** `*.go`


## IGNORE: Header Sanitization via Del()

**- Pattern:** Relying on `http.Header.Del()` to remove non-canonical or malformed headers (e.g. underscore variations like `Tailscale_User_Login`) for security sanitization.
**- Justification:** `Header.Del()` canonicalizes keys and fails to remove non-canonical variations that might be present in the map. Use `delete(headerMap, key)` instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This justification is correct, but could be more explicit about why Header.Del() fails. Explaining the canonicalization process makes the reasoning clearer and reinforces the correct pattern, which is especially helpful for an automated agent.

Suggested change
**- Justification:** `Header.Del()` canonicalizes keys and fails to remove non-canonical variations that might be present in the map. Use `delete(headerMap, key)` instead.
**- Justification:** `http.Header.Del()` first canonicalizes the key (e.g., `Tailscale_User_Login` becomes `Tailscale-User-Login`) before deleting. This means it will fail to remove the original non-canonical header if it exists in the map. To reliably sanitize headers, you must iterate over the map and use `delete(headerMap, key)` to remove the key as-is.

**- Files Affected:** `http.go`

## IGNORE: Manual Context Cleanup

**- Pattern:** Manually calling `cancel()` on multiple error return paths in constructors or setup functions.
**- Justification:** Prone to errors if a path is missed. Use `defer func() { if err != nil { cancel() } }()` pattern instead.
**- Files Affected:** `*.go`

## IGNORE: CI/CD Workflow Overhaul

**- Pattern:** Replacing the existing granular `autorelease.yml` workflow steps with a single `mise run ci` command, or removing `scorecard.yml`.
**- Justification:** The project prefers the existing granular workflow structure and `scorecard.yml` should be preserved. Large overhauls of the CI configuration are consistently rejected.
**- Files Affected:** `.github/workflows/*.yml`, `mise.toml`