Define controller networks using the network name#431
Draft
lucaslorentz wants to merge 1 commit intomasterfrom
Draft
Define controller networks using the network name#431lucaslorentz wants to merge 1 commit intomasterfrom
lucaslorentz wants to merge 1 commit intomasterfrom
Conversation
c56026b to
2e6a099
Compare
lucaslorentz
commented
Nov 28, 2022
lucaslorentz
commented
Nov 28, 2022
2e6a099 to
a6375c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is only 1 way to configure CDP in distributed mode (controllers + servers):
CADDY_CONTROLLER_NETWORKwith network CIDR on both controller and serversWhat I'm changing:
CADDY_CONTROLLER_NETWORKcan be configured with the network name when configured in controllers, or completely omitted if the controller is connected to a single network.CADDY_CONTROLLER_NETWORKcan be replaced byCADDY_CONTROLLER_URLon servers, and servers will fetch the controller network information from a new endpoint exposed in controllers.CADDY_CONTROLLER_NETWORKandCADDY_CONTROLLER_URLare omitted on servers, they will allow configuration from all networks they're connected to.This simplifies configuration for distributed mode and removes the need to hardcode network CIDRs:
Fixes #286