Skip to content

Move "no tasks in running state" log to debug level #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucaslorentz merged 1 commit into from
Mar 12, 2026
+3 −5
Merged

Move "no tasks in running state" log to debug level #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generator/services.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func (g *CaddyfileGenerator) getServiceTasksIps(service *swarm.Service, logger *
}

if !hasRunningTasks {
logger.Warn("Service has no tasks in running state", zap.String("service", service.Spec.Name), zap.String("serviceId", service.ID))
logger.Debug("Service has no tasks in running state", zap.String("service", service.Spec.Name), zap.String("serviceId", service.ID))

} else if len(tasksIps) == 0 {
logger.Warn("Service is not in same network as caddy", zap.String("service", service.Spec.Name), zap.String("serviceId", service.ID))
Expand Down
6 changes: 2 additions & 4 deletions generator/services_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,7 @@ func TestServiceTasks_Empty(t *testing.T) {
" reverse_proxy\n" +
"}\n"

const expectedLogs = commonLogs +
`WARN Service has no tasks in running state {"service": "service", "serviceId": "SERVICEID"}` + newLine
const expectedLogs = commonLogs

testGeneration(t, dockerClient, func(options *config.Options) {
options.ProxyServiceTasks = true
Expand Down Expand Up @@ -267,8 +266,7 @@ func TestServiceTasks_NotRunning(t *testing.T) {
" reverse_proxy\n" +
"}\n"

const expectedLogs = commonLogs +
`WARN Service has no tasks in running state {"service": "service", "serviceId": "SERVICEID"}` + newLine
const expectedLogs = commonLogs

testGeneration(t, dockerClient, func(options *config.Options) {
options.ProxyServiceTasks = true
Expand Down
Loading