Skip to content

refactor: replace empty slice literal with var #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucassabreu merged 1 commit into from
Jun 20, 2025
Merged

refactor: replace empty slice literal with var #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@
return w, nil
}

ws := []dto.Workspace{}
var ws []dto.Workspace

Check warning on line 200 in api/client.go

View check run for this annotation

Codecov / codecov/patch

api/client.go#L200 

Added line #L200 was not covered by tests

n := strhlp.Normalize(strings.TrimSpace(f.Name))
for i := 0; i < len(w); i++ {
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/task/edit/edit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,8 @@ func TestCmdEdit(t *testing.T) {

b := true
e := time.Hour * 32
us := []string{}
var us []string

c.On("UpdateTask", api.UpdateTaskParam{
Workspace: "w",
TaskID: "t-1",
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/task/util/read-flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@
}

if cmd.Flags().Changed("no-assignee") {
a := []string{}
var a []string

Check warning on line 98 in pkg/cmd/task/util/read-flags.go

View check run for this annotation

Codecov / codecov/patch

pkg/cmd/task/util/read-flags.go#L97-L98 

Added lines #L97 - L98 were not covered by tests
p.AssigneeIDs = &a
}

Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/time-entry/util/description-completer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
return dc.descriptions
}

ss := []string{}
var ss []string

Check warning on line 79 in pkg/cmd/time-entry/util/description-completer.go

View check run for this annotation

Codecov / codecov/patch

pkg/cmd/time-entry/util/description-completer.go#L78-L79 

Added lines #L78 - L79 were not covered by tests
for _, t := range tes {
ss = append(ss, t.Description)
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmdutil/flags_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ func TestXorFlagSet(t *testing.T) {
t.Run(tc.name, func(t *testing.T) {
fs := pflag.NewFlagSet("test", pflag.ContinueOnError)
flags := make([]string, len(tc.param))
args := []string{}
var args []string

for fl := range tc.param {
flags = append(flags, fl)
fs.Bool(fl, false, "help")
Expand Down
Loading