Skip to content

Conversation

ckuran
Copy link
Contributor

@ckuran ckuran commented Dec 11, 2024

The original ones are barely visible.

Original comment view:

Summary - Lines: 87.97% 🔽 | Methods: 81.05% 🔼
Summary - Lines: 87.97% ⏹️ | Methods: 81.05% ⏹️

New comment view:

Summary - Lines: 87.97% ↙️ | Methods: 81.05% ↗️
Summary - Lines: 87.97% ⏏️ | Methods: 81.05% ⏏️

Sorry for a big PR, it might be because I commit from a Linux system. You can add a commit which will reset bin/index.ts and change just the changed lines.

@ckuran ckuran changed the title Change emoticons feat: change emoticons Dec 11, 2024
@lucassabreu
Copy link
Owner

i think the ⏏️ might get confusing, because of the triangle, keeping the same is better i think.

better yet would be to have options so people can choose what to use there

@ckuran
Copy link
Contributor Author

ckuran commented Dec 11, 2024

i think the ⏏️ might get confusing, because of the triangle, keeping the same is better i think.

My main idea was to select an emoticon which has 20x20 instead of 16x16 pixels. When you use a high-density screen, it's hard to see the detail of the 16x16 icon. Using the old icon might cause inconsistency by using 16x16 icon with 20x20 in one line. You can propose any other icon here but I suggest 20x20.

Summary - Lines: 87.97% ↙️ | Methods: 81.05% ⏹️

better yet would be to have options so people can choose what to use there

Making it configurable might be a good idea for the future.

@lucassabreu lucassabreu merged commit b3fd398 into lucassabreu:main Dec 20, 2024
1 of 2 checks passed
@lucassabreu
Copy link
Owner

hi @ckuran , i added the support to choose the emojis, you can see how it looks here:
#31 (comment)

and how to setup here:
https://github.com/lucassabreu/comment-coverage-clover/blob/main/.github/workflows/example.yml#L253-L265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants