Skip to content

Custom bottom content offset for BottomSheet#159

Open
asdafa3 wants to merge 7 commits intolucaszischka:mainfrom
asdafa3:main
Open

Custom bottom content offset for BottomSheet#159
asdafa3 wants to merge 7 commits intolucaszischka:mainfrom
asdafa3:main

Conversation

@asdafa3
Copy link

@asdafa3 asdafa3 commented Apr 9, 2024

Change

I made a rather tiny change for convenience in a project where I use your awesome bottomsheet implementation. That is, normally the content offset when the bottomsheet is dragged to the bottom of the screen is tied to the safe area of the device. As we have a TabBar and optional sticky content at the bottom of the screen, we want the bottomsheet to align above this content when dragged all the way down. Hence we added an additional argument to the bottomsheet initializer to set this offset on top of the safe area for a bit more control over the alignment process. This is just our change, I hope this can be in the one or other way be integrated as a feature. Changes to the adaptations to better match the coding style of the project are appreciated. I also added a screenshot to illustrate the change below.

Screenshot

offset_includes_tabbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Thank You ❤️ For people who appreciate my work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants